From 5c5ed854e42a6be984774ee69d4a2a79d764e827 Mon Sep 17 00:00:00 2001
From: Thatsaphorn Atchariyaphap <thatsaphorn@outlook.de>
Date: Tue, 22 Jul 2025 23:42:18 +0200
Subject: [PATCH] Code Cleanup

---
 .../transport => common/dtos}/Dto.java        |  2 +-
 .../shared/rest/RestTemplateConfig.java       | 21 -------------
 .../shared/rest/RestTemplateConfigTest.java   | 30 -------------------
 .../contact/model/ContactRequestDto.java      |  2 +-
 4 files changed, 2 insertions(+), 53 deletions(-)
 rename backend/common/src/main/java/dev/rheinsw/{shared/transport => common/dtos}/Dto.java (80%)
 delete mode 100644 backend/common/src/main/java/dev/rheinsw/shared/rest/RestTemplateConfig.java
 delete mode 100644 backend/common/src/test/java/dev/rheinsw/shared/rest/RestTemplateConfigTest.java

diff --git a/backend/common/src/main/java/dev/rheinsw/shared/transport/Dto.java b/backend/common/src/main/java/dev/rheinsw/common/dtos/Dto.java
similarity index 80%
rename from backend/common/src/main/java/dev/rheinsw/shared/transport/Dto.java
rename to backend/common/src/main/java/dev/rheinsw/common/dtos/Dto.java
index e820ef2..2b1ba6e 100644
--- a/backend/common/src/main/java/dev/rheinsw/shared/transport/Dto.java
+++ b/backend/common/src/main/java/dev/rheinsw/common/dtos/Dto.java
@@ -1,4 +1,4 @@
-package dev.rheinsw.shared.transport;
+package dev.rheinsw.common.dtos;
 
 import java.io.Serializable;
 
diff --git a/backend/common/src/main/java/dev/rheinsw/shared/rest/RestTemplateConfig.java b/backend/common/src/main/java/dev/rheinsw/shared/rest/RestTemplateConfig.java
deleted file mode 100644
index 61767db..0000000
--- a/backend/common/src/main/java/dev/rheinsw/shared/rest/RestTemplateConfig.java
+++ /dev/null
@@ -1,21 +0,0 @@
-package dev.rheinsw.shared.rest;
-
-import org.springframework.beans.factory.annotation.Qualifier;
-import org.springframework.cloud.client.loadbalancer.LoadBalanced;
-import org.springframework.context.annotation.Bean;
-import org.springframework.context.annotation.Configuration;
-import org.springframework.web.client.RestTemplate;
-
-/**
- * @author Thatsaphorn Atchariyaphap
- * @since 23.04.25
- */
-@Configuration
-public class RestTemplateConfig {
-
-    @Bean
-    public RestTemplate plainRestTemplate() {
-        return new RestTemplate();
-    }
-
-}
\ No newline at end of file
diff --git a/backend/common/src/test/java/dev/rheinsw/shared/rest/RestTemplateConfigTest.java b/backend/common/src/test/java/dev/rheinsw/shared/rest/RestTemplateConfigTest.java
deleted file mode 100644
index ef33c5c..0000000
--- a/backend/common/src/test/java/dev/rheinsw/shared/rest/RestTemplateConfigTest.java
+++ /dev/null
@@ -1,30 +0,0 @@
-package dev.rheinsw.shared.rest;
-
-import org.junit.jupiter.api.Test;
-import org.springframework.web.client.RestTemplate;
-
-import static org.junit.jupiter.api.Assertions.*;
-
-class RestTemplateConfigTest {
-
-    private final RestTemplateConfig restTemplateConfig = new RestTemplateConfig();
-
-    @Test
-    void plainRestTemplate_shouldReturnNonNullRestTemplate() {
-        // Act
-        RestTemplate restTemplate = restTemplateConfig.plainRestTemplate();
-
-        // Assert
-        assertNotNull(restTemplate, "RestTemplate should not be null");
-    }
-
-    @Test
-    void plainRestTemplate_shouldCreateNewInstanceEachTime() {
-        // Act
-        RestTemplate restTemplate1 = restTemplateConfig.plainRestTemplate();
-        RestTemplate restTemplate2 = restTemplateConfig.plainRestTemplate();
-
-        // Assert
-        assertNotSame(restTemplate1, restTemplate2, "Each call should create a new RestTemplate instance");
-    }
-}
diff --git a/backend/server/src/main/java/dev/rheinsw/server/internal/contact/model/ContactRequestDto.java b/backend/server/src/main/java/dev/rheinsw/server/internal/contact/model/ContactRequestDto.java
index dd19904..df552e2 100644
--- a/backend/server/src/main/java/dev/rheinsw/server/internal/contact/model/ContactRequestDto.java
+++ b/backend/server/src/main/java/dev/rheinsw/server/internal/contact/model/ContactRequestDto.java
@@ -1,6 +1,6 @@
 package dev.rheinsw.server.internal.contact.model;
 
-import dev.rheinsw.shared.transport.Dto;
+import dev.rheinsw.common.dtos.Dto;
 
 /**
  * @param company optional